[Enhancement]: Abstract password hashing and validation #15

Merged
je-sendra merged 0 commits from refs/pull/15/head into main 2024-12-26 11:54:18 +00:00
je-sendra commented 2024-12-26 09:57:20 +00:00 (Migrated from autotime-api.vewtech.net)

PR

Fixes #13

Description

The password hashing code was on the AuthService and "hardcoded" to use the BCrypt hashing algorithm.

This PR adds abstraction so the hashing algorithm can be set in the app settings

Added dependencies

Testing

Checklist

  • My code follows the coding and style conventions for this project
  • I made a self-evaluation of my code
  • I commented my code, specially in hard to understand areas
  • I made the corresponding changes to the documentation
  • My changes generate no new warnings
  • I created unit tests for my code

Additional context

<!-- Thanks for contributing to Charwiki. Please fill this form to create a new pull request. --> # PR ## Related issue Fixes #13 ## Description <!-- Please include a summary of the change and what problem(s) it solves. --> The password hashing code was on the AuthService and "hardcoded" to use the BCrypt hashing algorithm. This PR adds abstraction so the hashing algorithm can be set in the app settings ## Added dependencies <!-- Please list any added dependencies for this change. --> ## Testing <!-- Please describe all tests ran to verify your changes. Provide instructions to reproduce them. Also list any relevant detail about your testing configuration. Please describe the added unit tests as well. --> ## Checklist - [x] My code follows the coding and style conventions for this project - [x] I made a self-evaluation of my code - [x] I commented my code, specially in hard to understand areas - [ ] I made the corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I created unit tests for my code <!-- If an item in the checklist is not applicable, please mark it, and ideally explain why in this section, below the checklist. --> ## Additional context <!-- Please add any other context about the pull request here. -->
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LokiShell/Charwiki!15
No description provided.